Fix span error tagging in GO YARPC/gRPC #2282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kexiongliu123
commented
Aug 11, 2024
kexiongliu123
commented
- Created span earlier and added missing span error tag
- Added span tag for gRPC status code(based on https://github.com/yarpc/yarpc-go/blob/dev/yarpcerrors/codes.go#L29)
- Added span tag for component
|
|
ChenX1993
reviewed
Aug 12, 2024
ChenX1993
reviewed
Aug 12, 2024
ChenX1993
reviewed
Aug 12, 2024
biosvs
requested changes
Aug 14, 2024
|
Also, do you have access to the builds? Circular dependency was introduced, code is uncompilable. |
vprithvi
reviewed
Aug 15, 2024
ChenX1993
reviewed
Aug 16, 2024
biosvs
reviewed
Aug 16, 2024
biosvs
reviewed
Aug 19, 2024
biosvs
approved these changes
Aug 20, 2024
|
LGTM, one test is failing though. |
ChenX1993
reviewed
Aug 20, 2024
api/transport/propagation.go
Outdated
| // Returns the given error | ||
| // UpdateSpanWithErr logs an error to the span. Prefer UpdateSpanWithErrAndCode | ||
| // for including an error code in addition to the error message. | ||
| // Deprecated: Use UpdateSpanWithErrAndCode instead. | ||
| func UpdateSpanWithErr(span opentracing.Span, err error) error { | ||
| if err != nil { | ||
| span.SetTag("error", true) | ||
| span.LogFields(opentracinglog.String("event", err.Error())) |
There was a problem hiding this comment.
Let's correct the span log fields:
span.LogFields(
opentracinglog.String("event", "error"),
opentracinglog.String("message", err.Error()),
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.